Add exclude and grep functions #11

shanson7 · 2018-01-19T18:04:51Z

No description provided.

Aergonus · 2018-01-19T18:23:37Z

expr/func_grep.go

+			outputs = append(outputs, serie)
+		}
+	}
+	return outputs, nil


Is it okay to return an empty slice? Should we provide a warning if it's empty?

Yes, an empty slice is fine. No need to warn.

I looked around guess convention is to send back empty. (y)

Aergonus · 2018-01-19T18:24:10Z

expr/func_grep_test.go

+			"this",
+			[]string{"series.name.this.ok"},
+			[]string{"series.name.this.ok"},
+			[]string{},


On the same idea, do we need a test to specify what happens when grep finds nothing?

This test has an "exclude" that excludes everything. It's the same code at that point.

Aergonus · 2018-01-19T18:31:40Z

lgtm, I wonder if there'll be problems with regex escaping or specialized names, but I don't know enough about the project :P

Add exclude and grep functions

35e5f94

shanson7 assigned Aergonus and yogeswaran Jan 19, 2018

Aergonus reviewed Jan 19, 2018

View reviewed changes

Aergonus merged commit ea3b672 into feature_grepExclude Jan 19, 2018

Aergonus deleted the grepExclude branch January 19, 2018 18:31

Provide feedback