-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a landing page for the documentation #110
Conversation
3fdb2c9
to
33bfff2
Compare
Mm. We changed the GitHub Actions to not run the tests if nothing in src/ changed, which seemed clever at the time and like a way to save time - but of course, no our required status checks aren't reported 😓 |
I've iterated on this a bit. I force pushed my changes, and the version with my changes can be previewed at https://godlygeek.github.io/pystack/ |
About I'm also not a big fan of the red squiggles under some of the words, probably a quirk of the way the screenshots were made in the first place. |
Hm, yes...
Also yes... @pablogsal Would you like to take another swing at these? Or I can do it, but then we'll wind up with PuTTY instead of - iTerm2, I guess? We'll have Windows title bars instead of Mac ones, at least (or crop the title bars out 🤷) |
Is not iterm, is https://carbon.sh. I can give it a go this night but if you want to replace them, just generate images with transparent backgrounds there |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions.
Should one of the blurb mention that you'll also get stack traces for threads not owned by the interpreter?
There's also this article that may be worthy of inclusion in the media section.
Hummm, but this article does not speak itself about pystack directly no? Is more about BB in general more than focusing on the tool |
To make thinks shiny and cool, add a landing page instead of using the Sphinx index page. Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Fixed |
This was preenting us to get the required checks in PRs only when docs are updated. Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
2c48616
to
000ff46
Compare
In the latest iteration of the arch Linux container, we need to also deactivate seccomp to be able to run `gcore` and `ptrace` in the container. In addition to that, seems that the new libc is too optimized and some of our tests are too strict over the number of native frames that must be present in pthread-based threads, so we need to be a bit more permissive. Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
To make thinks shiny and cool, add a landing page instead of using the
Sphinx index page.