Stop telling setuptools our headers are in src/ #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They're actually in `src/pystack/_pystack`, and the build works fine without passing this flag. Moreover, this flag causes builds to fail if `pkg-config` returns `include_dirs` for building against our dependencies, because we pass the `include_dirs` keyword argument twice. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #135 +/- ##
=======================================
Coverage 90.00% 90.00%
=======================================
Files 48 48
Lines 5575 5575
Branches 873 873
=======================================
Hits 5018 5018
Misses 557 557
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pablogsal
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They're actually in
src/pystack/_pystack, and the build works fine without passing this flag. Moreover, this flag causes builds to fail ifpkg-configreturnsinclude_dirsfor building against our dependencies, because we pass theinclude_dirskeyword argument twice.