Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a warning that slipped in #154

Merged
merged 1 commit into from
Nov 18, 2023
Merged

Conversation

godlygeek
Copy link
Contributor

We're comparing integers of different signedness here.

We're comparing integers of different signedness here.

Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
@godlygeek godlygeek self-assigned this Nov 17, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (65f8d4e) 89.71% compared to head (5d2808b) 89.77%.

Files Patch % Lines
src/pystack/_pystack/pythread.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
+ Coverage   89.71%   89.77%   +0.05%     
==========================================
  Files          48       48              
  Lines        5505     5505              
  Branches      873      873              
==========================================
+ Hits         4939     4942       +3     
+ Misses        566      563       -3     
Flag Coverage Δ
cpp 75.00% <0.00%> (+0.13%) ⬆️
python_and_cython 99.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pablogsal pablogsal enabled auto-merge (squash) November 18, 2023 02:53
@pablogsal pablogsal merged commit 6816fe4 into bloomberg:main Nov 18, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants