Added drain functionality to the Sequencer #110
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Damian adamian@bloomberg.net
Describe your changes
Added a
drain()
member function to theSequencer
class which is identical in signature toDispatcher::drain()
. While draining can be done directly from the dispatcher object itself, there are situations when the jobs enqueued in the Sequencer may post additional sub-jobs in theDispatcher
. If theDispatcher
drains, these jobs would fail since posting is disallowed while draining. By draining theSequencer
we allow all jobs to complete successfully.Testing performed
Ran unit tests and replaced
Dispatcher::drain()
withSequencer::drain()