Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added drain functionality to the Sequencer #110

Merged
merged 1 commit into from
Aug 23, 2019

Conversation

accelerated
Copy link
Contributor

Signed-off-by: Alexander Damian adamian@bloomberg.net

Describe your changes
Added a drain() member function to the Sequencer class which is identical in signature to Dispatcher::drain(). While draining can be done directly from the dispatcher object itself, there are situations when the jobs enqueued in the Sequencer may post additional sub-jobs in the Dispatcher. If the Dispatcher drains, these jobs would fail since posting is disallowed while draining. By draining the Sequencer we allow all jobs to complete successfully.

Testing performed
Ran unit tests and replaced Dispatcher::drain() with Sequencer::drain()

Signed-off-by: Alexander Damian <adamian@bloomberg.net>
@accelerated accelerated merged commit 8675304 into bloomberg:master Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant