New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix drain issue when coroutine is still running #113

Merged

accelerated merged 1 commit into bloomberg:master from accelerated:master

Aug 28, 2019

Contributor

accelerated commented Aug 28, 2019

Signed-off-by: Alexander Damian adamian@bloomberg.net

Describe your changes

Properly set the idle flag in the coroutine processing function to determine when a thread is still active. This could cause drain() not to wait fully if there was still one task executing.
Added more asserts in the ContiguousPoolAllocator class to catch invalid states.

Testing performed
Ran unit tests. Also tested shutting down an application and made sure all resources used by the Dispatcher were cleaned.


          Fix drain issue when coroutine is still running

715c500

Signed-off-by: Alexander Damian <adamian@bloomberg.net>

accelerated merged commit efc53a5 into bloomberg:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet