Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch and rethrow all stack unwind exceptions #135

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

accelerated
Copy link
Contributor

@accelerated accelerated commented Nov 9, 2020

Describe your changes
Ensure proper catch/rethrow of coroutine unwind exceptions

Testing performed
Normal test suite

Signed-off-by: Alexander Damian adamian@bloomberg.net

arosenzweig3
arosenzweig3 previously approved these changes Nov 9, 2020
Copy link
Contributor

@arosenzweig3 arosenzweig3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@accelerated accelerated force-pushed the no-catch-all branch 3 times, most recently from 4718e40 to c2ae4a4 Compare November 9, 2020 16:21
@accelerated accelerated changed the title Remove catch all blocks Catch and rethrow all stack unwind exceptions Nov 9, 2020
Signed-off-by: Alexander Damian <adamian@bloomberg.net>
@accelerated accelerated merged commit 8e06998 into bloomberg:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants