Fixed bug where we were incorrectly offsetting flash reads (see #40)

bloombloombloom · May 14, 2022 · 158a32a · 158a32a
1 parent 814b98d
commit 158a32a
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/DebugToolDrivers/Protocols/CMSIS-DAP/VendorSpecific/EDBG/AVR/EdbgAvr8Interface.cpp b/src/DebugToolDrivers/Protocols/CMSIS-DAP/VendorSpecific/EDBG/AVR/EdbgAvr8Interface.cpp
@@ -1376,8 +1376,12 @@ namespace Bloom::DebugToolDrivers::Protocols::CmsisDap::Edbg::Avr
                 int pagesRequired = static_cast<int>(bytes / pageSize);
                 TargetMemoryBuffer memoryBuffer;
 
-                for (auto i = 1; i <= pagesRequired; i++) {
-                    auto pageBuffer = this->readMemory(type, startAddress + (pageSize * i), pageSize);
+                for (auto i = 0; i < pagesRequired; i++) {
+                    auto pageBuffer = this->readMemory(
+                        type,
+                        startAddress + static_cast<std::uint32_t>(pageSize * i),
+                        pageSize
+                    );
                     memoryBuffer.insert(memoryBuffer.end(), pageBuffer.begin(), pageBuffer.end());
                 }