Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joshua Cheney #1312

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Joshua Cheney #1312

wants to merge 17 commits into from

Conversation

helloitisjoshua
Copy link

@cholman here's my sprint.

The media queries aren't working properly. Two TL's (Issac Rutlege and Tim Shaker) and one SL (Sean Naleid) couldn't figure out why it wasn't working, but it is coded correctly for a 800 and 500 pixel width layout. You just have to comment out the layout you don't want to see. We spent an hour going over this and weren't able to come to a resolution. Tim is going to review the code as well.

@helloitisjoshua
Copy link
Author

@tmshkr here's the pull request.

@helloitisjoshua
Copy link
Author

@cholman, @tmshkr was able to locate my mistake, which was forgetting the viewport code. Everything else should be good to go. This change was uploaded a few minutes after the 3 hour time limit, though we (Isaac and myself) did spend over an hour in meetings figuring this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant