Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make registry_token variable optional #48

Closed
Kerwood opened this issue May 28, 2024 · 0 comments · Fixed by #49
Closed

feat: make registry_token variable optional #48

Kerwood opened this issue May 28, 2024 · 0 comments · Fixed by #49
Assignees

Comments

@Kerwood
Copy link

Kerwood commented May 28, 2024

The registry_token variable (action.yml#L20) is required for this action to run.

I am unsure as to where the environment variable GH_TOKEN is actually used and how it is authenticating. But its an issue if you want to use other image registries than ghcr.oi and need to use docker-credential-helpers, eg. for authenticating to Google Artifact Registry.

My proposal is to make registry_token optional and still make the bluebuild build command push the image but not authenticate if the registry_token is not set.

That way you could add a docker-credential-helper and docker login step before the blue-build action which would enable the use of other registries.

@Kerwood Kerwood changed the title Make registry_token variable optional feat: make registry_token variable optional May 28, 2024
@gmpinder gmpinder self-assigned this May 28, 2024
@gmpinder gmpinder linked a pull request May 29, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants