Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate parsing into common_functions #211

Merged
merged 1 commit into from
Oct 11, 2019
Merged

Commits on Oct 8, 2019

  1. Consolidate parsing into common_functions

    This commit re-factors the adding of parsed arguments into a set
    of functions that add related arguments. Each script can then simply
    use some of these function as parent parsers when setting up the
    ArgumentParser for that script.
    
    Note: there are still some issues with how arguments are passed through
    from run_end_to_end to the other scripts. For instance, the scenario
    name is required for run_scenario.py but in theory not for
    run_end_to_end.py. However, run_end_to_end.py calls run_scenario.py, so
    you will get an error message if you don't provide it in
    run_end_to_end.py and the error message will be a somewhat confusing
    combination of run_end_to_end.py and run_scenario.py
    
    One solution could be to get rid of scenario_id and make scenario a
    required argument. The value can be either the ID or the name, and we
    can add some functionality to smartly determine what is provided and
    get the equivalent name/id from the db (if needed).
    gerritdm committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    cd17d79 View commit details
    Browse the repository at this point in the history