This repository has been archived by the owner on Dec 1, 2021. It is now read-only.
use byte arrays to remove inexact floating point number literals #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkng
changed the title
tkng
changed the title
primenumber
reviewed
Jun 5, 2020
| #elif defined USE_NEON || defined USE_AVX | ||
| static Base<{{ node.dtype.cpptype() }}>::type {{ node.name }}_raw[] = { | ||
| alignas(16) static unsigned char {{ node.name }}_raw[] = { |
There was a problem hiding this comment.
Where from 16-byte align?
|
|
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this patch does to fix the issue.
Conversion between floating point value↔️ decimal string representation cause some small error.
In this pull request, I removed floating point number literals. Instead, parameters are represented as an array of unsigned char, then casted to floating point number by
reinterpret_cast.Link to any relevant issues or pull requests.
fix #1078