This repository has been archived by the owner on Dec 1, 2021. It is now read-only.
Enable data prefetch for param tuner #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlpng
changed the title
iizukak
reviewed
May 15, 2019
| @@ -135,7 +135,7 @@ def setup_dataset(config, subset, rank): | |||
| dataset_class = config.DATASET_CLASS | |||
| dataset_kwargs = dict((key.lower(), val) for key, val in config.DATASET.items()) | |||
| dataset = dataset_class(subset=subset, **dataset_kwargs) | |||
| enable_prefetch = dataset_kwargs.pop("enable_prefetch", False) | |||
| enable_prefetch = dataset_kwargs.pop("enable_prefetch", False) if subset == 'train' else False | |||
There was a problem hiding this comment.
Why enable_prefetch enable for training set only?
Please add comment.
ruimashita
pushed a commit
that referenced
this pull request
Jun 26, 2019
* allow dataset prefetch only for training * remove to-do flag * add comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Description
Previously the processes would not terminate cleanly when the
DATASET.ENABLE_PREFETCHisTrue, and cause the trial cue to halt. This is a quick fix to avoid the problem by only enable the data prefetch for the training of the parameter tuner.How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: