Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

update config of example and README #608

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

LucienZhang
Copy link
Contributor

the shape of cifar-10 should 32x32, and updated the description in README.

@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Nov 11, 2019
@iizukak
Copy link
Member

iizukak commented Nov 21, 2019

@LucienZhang Test dose not passed. Please check CI :)

@bo-code-review-bot
Copy link

This PR needs Approvals as follows.

  • Ownership Approval for / from iizukak, tkng, ruimashita
  • Readability Approval for Python from tkng, tsawada

Please choose reviewers and requet reviews!

Click to see how to approve each reviews

You can approve this PR by triggered comments as follows.

  • Approve all reviews requested to you (readability and ownership) and LGTM review
    Approval, LGTM

  • Approve all ownership reviews
    Ownership Approval or OA

  • Approve all readability reviews
    Readability Approval or RA

  • Approve specified review targets

    • Example of Ownership Reviewer of /: Ownership Approval for / or OA for /
    • Example of Readability Reviewer of Python: Readability Approval for Python or RA for Python
  • Approve LGTM review
    LGTM

See all trigger comments

Please replace [Target] to review target

  • Ownership Approval
    • Ownership Approval for [Target]
    • OA for [Target]
    • Ownership Approval
    • OA
    • Approval
  • Readability Approval
    • Readability Approval for [Target]
    • RA for [Target]
    • [Target] Readability Approval
    • [Target] RA
    • Readability Approval
    • RA
    • Approval
  • LGTM
    • LGTM
    • lgtm

Copy link
Member

@iizukak iizukak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LucienZhang
Thank you for the PR.
This PR include some different changes.

  1. Fix the documentation.
  2. Change config values related with CIFAR 10 image size
  3. Other config changes.

Can you separate PR?
And please remove change in license header.

@@ -9,79 +9,77 @@
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# WITH WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why you change this?

@iizukak
Copy link
Member

iizukak commented Dec 23, 2019

I recommend you to create issues.

@Joeper214 Joeper214 added WIP Work in progress wontfix This will not be worked on labels Jan 23, 2020
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ iizukak
❌ LucienZhang
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ iizukak
❌ LucienZhang
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically WIP Work in progress wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants