Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

tf_upgrade_v2 for blueoil/layers #927

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

ytfksw
Copy link
Contributor

@ytfksw ytfksw commented Mar 17, 2020

What this patch does to fix the issue.

I converted blueoil/layer with the command line tool tf_upgrade_v2 to run on tensorflow2.

Since tf.contrib is not supported, I change it manually.

Here's what I did:

  1. install newest tenosrflow (tensorflow-gpu==1.5.2)
  2. Run the upgrade script tf_upgrade_v2
  3. convert tf.contrib manually
    • tf.contrib.layers.batch_norm -> tf.compat.v1.layers.batch_normalization
    • tf.contrib.layers.fully_connected -> tf.keras.layers.Dense
  4. Check the upgrade report for warnings and errors
  5. Run test (make test)
  6. [WIP] Make sure there is no change in accuracy

Link to any relevant issues or pull requests.

@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Mar 17, 2020
@ytfksw ytfksw self-assigned this May 26, 2020
@CLAassistant
Copy link

CLAassistant commented Jun 12, 2020

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants