feat: add with_handler method to EvmBuilder #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
force-pushed
the
dan/add-with-handler
branch
from
eef91b4 to
98dbc7e
Compare
rakita
reviewed
Feb 24, 2024
crates/revm/src/builder.rs
Outdated
Comment on lines
206
to
208
| /// // set up empty handler cfg | ||
| /// let handler = HandlerCfg::new(SpecId::LATEST); | ||
| /// let builder = builder.with_handler_cfg(handler); |
There was a problem hiding this comment.
Would remove this lines, they can be confusing
Suggested change
| /// // set up empty handler cfg | |
| /// let handler = HandlerCfg::new(SpecId::LATEST); | |
| /// let builder = builder.with_handler_cfg(handler); |
There was a problem hiding this comment.
Second comment will address why you needed this previously: #1124 (comment)
rakita
reviewed
Feb 24, 2024
crates/revm/src/builder.rs
Outdated
| /// // build the EVM | ||
| /// let evm = builder.build(); | ||
| /// ``` | ||
| pub fn with_handler( |
There was a problem hiding this comment.
This function is inside:
impl<'a, EXT, DB: Database> EvmBuilder<'a, HandlerStage, EXT, DB> {
But it should be in:
impl<'a, BuilderStage, EXT, DB: Database> EvmBuilder<'a, BuilderStage, EXT, DB> {
Reason for this is that with_handler can be called from both HandlerStage and SetGenericStage
There was a problem hiding this comment.
ah I see, yeah it makes sense to call it from either handler or setgeneric stages
rakita
approved these changes
Feb 24, 2024
Merged
fubuloubu
pushed a commit
to ApeWorX/revm
that referenced
this pull request
Apr 11, 2024
* feat: add with_handler method to EvmBuilder * improve docs * add imports to docs * fix docs * move with_handler to BuilderStage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a method to make it possible to add a specific handler, for example a handler other than optimism or mainnet, to the evm builder.