Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pop_address should use crate scope #1410

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

rakita
Copy link
Member

@rakita rakita commented May 13, 2024

closes #1401

Copy link
Contributor

Valgrind Results:

==4131== Cachegrind, a cache and branch-prediction profiler
==4131== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==4131== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==4131== Command: target/release/snailtracer
==4131== 
--4131-- warning: L3 cache found, using its data for the LL simulation.
Running snailtracer example!
elapsed: 1.829999968s
==4131== 
==4131== I   refs:      429,372,260
==4131== I1  misses:          3,199
==4131== LLi misses:          2,812
==4131== I1  miss rate:        0.00%
==4131== LLi miss rate:        0.00%
==4131== 
==4131== D   refs:      206,205,215  (133,650,791 rd   + 72,554,424 wr)
==4131== D1  misses:        321,926  (    182,218 rd   +    139,708 wr)
==4131== LLd misses:        137,712  (      4,339 rd   +    133,373 wr)
==4131== D1  miss rate:         0.2% (        0.1%     +        0.2%  )
==4131== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==4131== 
==4131== LL refs:           325,125  (    185,417 rd   +    139,708 wr)
==4131== LL misses:         140,524  (      7,151 rd   +    133,373 wr)
==4131== LL miss rate:          0.0% (        0.0%     +        0.2%  )

@rakita rakita merged commit 4666bd3 into main May 13, 2024
25 checks passed
@rakita rakita deleted the rakita/pop_address_scope branch May 13, 2024 07:32
This was referenced Jun 8, 2024
This was referenced Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pop_address should $crate
2 participants