-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(EOF): panic on empty input range, and continue exec after eofcreate #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakita
changed the title
Rakita/temp
fix(EOF): Fix pop order in call, and continue exec after eofcreate
Jun 7, 2024
rakita
changed the title
fix(EOF): Fix pop order in call, and continue exec after eofcreate
fix(EOF): panic on empty input range, and continue exec after eofcreate
Jun 7, 2024
Valgrind Results:
|
Note I assumed that there is wrong order of stack pop's for EXTCALL, but spec says that original impl was correct, and order is not same as CALL opcode. Order is: |
This was referenced Jun 11, 2024
Closed
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InstructionResult needs to be reset when eofcreate continues execution.
And Handle panic on empty range