-
Notifications
You must be signed in to change notification settings - Fork 589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: avoid cloning precompiles #1486
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
changed the title
perf: avoid cloning precompiles twice
perf: avoid cloning precompiles
Jun 4, 2024
DaniPopes
force-pushed
the
precompile-clone
branch
3 times, most recently
from
June 4, 2024 12:07
661b8b9
to
64a27a9
Compare
DaniPopes
force-pushed
the
precompile-clone
branch
from
June 10, 2024 13:49
64a27a9
to
9c670a4
Compare
DaniPopes
force-pushed
the
precompile-clone
branch
from
June 10, 2024 13:59
9c670a4
to
7af22d9
Compare
rakita
approved these changes
Jun 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea!
Added few nit changes:
- Return Fatal error to not panic.
PrecompileCow::Default
renamed toPrecompileCow::StaticRef
- Return Boxed iter from addresses and additionaly added HashMap for addresses in
Precompile
.
DaniPopes
commented
Jun 15, 2024
DaniPopes
commented
Jun 15, 2024
This was referenced Jun 17, 2024
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precompiles::new().clone().into()
would first clone the static default precompiles, then collect them into a new hashmap again inContextPrecompiles
. This shows up as about ~3% inEvm::transact
profiles.Avoid both cloning and collecting by using a CoW structure internally. This requires us to remove the
Deref
andDerefMut
implementations as the internal type will be different depending on whether we have the default static precompiles, or a custom map. This should be fine as we can still support all necessary operations without exposing the underlying map type.