Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some nits in bls12_381 precompiles #1495

Merged
merged 2 commits into from
Jun 8, 2024

Conversation

jtraglia
Copy link
Contributor

@jtraglia jtraglia commented Jun 7, 2024

I was reviewing the new precompiles and noticed some stuff. This PR does the following:

  • Fix a few typos.
  • Replace g2 with g1 in extract_g1_input.
  • Remove unnecessary type hint for input_fps.
  • Rephrase comment about filtering points at infinity in the MSMs.
    • I found the part about returning bytes a little confusing.
    • We had to do the same thing in ckzg by the way 😢

These look great though. Didn't spot any real issues.

Copy link
Collaborator

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! I like the new comments, I think this just needs a fmt fix

@jtraglia
Copy link
Contributor Author

jtraglia commented Jun 7, 2024

thanks! I like the new comments, I think this just needs a fmt fix

Thanks! And oops, should be good now.

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for review!
lgtm

@rakita rakita merged commit 8943b3a into bluealloy:main Jun 8, 2024
25 checks passed
@jtraglia jtraglia deleted the fix-nits-bls-precomp branch June 8, 2024 17:08
This was referenced Jun 8, 2024
This was referenced Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants