Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(EOF): Remove redundunt ext call gas cost #1513

Merged
merged 7 commits into from
Jun 11, 2024
Merged

Conversation

rakita
Copy link
Member

@rakita rakita commented Jun 11, 2024

cold cost was deducted twice.

Copy link
Contributor

github-actions bot commented Jun 11, 2024

Valgrind Results:

==3791== Cachegrind, a cache and branch-prediction profiler
==3791== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==3791== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==3791== Command: target/release/snailtracer
==3791== 
--3791-- warning: L3 cache found, using its data for the LL simulation.
Running snailtracer example!
elapsed: 1.811113202s
==3791== 
==3791== I   refs:      430,648,633
==3791== I1  misses:          3,176
==3791== LLi misses:          2,807
==3791== I1  miss rate:        0.00%
==3791== LLi miss rate:        0.00%
==3791== 
==3791== D   refs:      202,359,343  (131,535,012 rd   + 70,824,331 wr)
==3791== D1  misses:        339,192  (    198,938 rd   +    140,254 wr)
==3791== LLd misses:        137,818  (      4,329 rd   +    133,489 wr)
==3791== D1  miss rate:         0.2% (        0.2%     +        0.2%  )
==3791== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==3791== 
==3791== LL refs:           342,368  (    202,114 rd   +    140,254 wr)
==3791== LL misses:         140,625  (      7,136 rd   +    133,489 wr)
==3791== LL miss rate:          0.0% (        0.0%     +        0.2%  )

@rakita rakita merged commit 8742fc7 into main Jun 11, 2024
25 checks passed
@rakita rakita deleted the rakita/extcall_cold_cost branch June 11, 2024 19:31
This was referenced Jun 11, 2024
@github-actions github-actions bot mentioned this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant