-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Prague): Add EIP-7702 #1565
Conversation
if self.tx.authorization_list.is_some() { | ||
// Check if other fields are unset. | ||
if self.tx.max_fee_per_blob_gas.is_some() || !self.tx.blob_hashes.is_empty() { | ||
return Err(InvalidTransaction::AuthorizationListInvalidFields); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this not be BlobVersionedHashesNotSupported
? or something similar, this error is a bit vague since the error is that we have an auth list and blobs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, EnvTx sucks rn, as we have all fields in one struck. This error marks AuthorizationList TX which has set some fields by mistake.
Valgrind Results:
|
@onbjerg this should be okay to go. Need alloy-rs/alloy#964 and a new version of alloy-eips to be published. Have patches and disabled alloy as it has dependencies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Waiting for alloy-rs/alloy#950