refactor: load_account -> warm_preloaded_addresses #1584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
seems like storage slot is not written while comparing it with initial account load, should it also add entry for storage slot in pre execution? |
rakita
approved these changes
Jul 10, 2024
|
Can you merge it with main. PR 929d4b2 enabled this PR |
|
Cool, it is now passing tests |
Closed
hai-rise
pushed a commit
to risechain/revm
that referenced
this pull request
Jul 11, 2024
This was referenced Jul 12, 2024
Closed
Closed
Closed
Merged
j75689
pushed a commit
to j75689/revm
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1484