Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eip7702): Add tests and fix some bugs #1605

Merged
merged 8 commits into from
Jul 16, 2024
Merged

fix(eip7702): Add tests and fix some bugs #1605

merged 8 commits into from
Jul 16, 2024

Conversation

rakita
Copy link
Member

@rakita rakita commented Jul 11, 2024

Few things added, still WIP:

  • New temp command for eof validation
  • Decoding of eip7702 tx for statetests (Authotization is not included as json field)
  • Fix wrong gas per auth (It should be 2500)
  • Fix: get code from authorization.address and not from authority

@wtdcode
Copy link
Contributor

wtdcode commented Jul 16, 2024

Current revm 11.0 is conflicting with alloy-eips 0.1.5 (which includes alloy-rs/alloy@5d8dce4) because of lacking this PR.

   Compiling revm-primitives v6.0.0
error[E0107]: struct takes 0 generic arguments but 1 generic argument was supplied
  --> /home/mio/.cargo/registry/src/index.crates.io-6f17d22bba15001f/revm-primitives-6.0.0/src/env/eip7702.rs:9:16
   |
9  |     Signed(Vec<SignedAuthorization<Signature>>),
   |                ^^^^^^^^^^^^^^^^^^^----------- help: remove these generics
   |                |
   |                expected 0 generic arguments
   |
note: struct defined here, with 0 generic parameters
  --> /home/mio/.cargo/registry/src/index.crates.io-6f17d22bba15001f/alloy-eips-0.1.5/src/eip7702/auth_list.rs:75:12
   |
75 | pub struct SignedAuthorization {
   |            ^^^^^^^^^^^^^^^^^^^

@mattsse
Copy link
Collaborator

mattsse commented Jul 16, 2024

yanked the releases, should be done as minor, not patch

Copy link
Contributor

github-actions bot commented Jul 16, 2024

Valgrind Results:

==4076== Cachegrind, a cache and branch-prediction profiler
==4076== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==4076== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==4076== Command: target/release/snailtracer
==4076== 
--4076-- warning: L3 cache found, using its data for the LL simulation.
Running snailtracer example!
elapsed: 1.841954298s
==4076== 
==4076== I   refs:      427,040,162
==4076== I1  misses:          3,322
==4076== LLi misses:          2,849
==4076== I1  miss rate:        0.00%
==4076== LLi miss rate:        0.00%
==4076== 
==4076== D   refs:      204,076,940  (132,268,735 rd   + 71,808,205 wr)
==4076== D1  misses:        339,968  (    199,994 rd   +    139,974 wr)
==4076== LLd misses:        137,816  (      4,496 rd   +    133,320 wr)
==4076== D1  miss rate:         0.2% (        0.2%     +        0.2%  )
==4076== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==4076== 
==4076== LL refs:           343,290  (    203,316 rd   +    139,974 wr)
==4076== LL misses:         140,665  (      7,345 rd   +    133,320 wr)
==4076== LL miss rate:          0.0% (        0.0%     +        0.2%  )

@rakita rakita marked this pull request as ready for review July 16, 2024 13:21
@rakita
Copy link
Member Author

rakita commented Jul 16, 2024

Will merge it with alloy patches and we can make additional PR that uses crates version

@rakita rakita merged commit c04c2b2 into main Jul 16, 2024
26 checks passed
@github-actions github-actions bot mentioned this pull request Jul 16, 2024
@gakonst gakonst deleted the rakita/eip7702_fixes branch July 16, 2024 16:56
j75689 pushed a commit to j75689/revm that referenced this pull request Aug 1, 2024
* fix(eip7702): Add tests and fix some bugs

* passing tests

* remove disabling of state clear, fix eip7702

* fmt/clippy rm comments

* add CI for eof and prague tests

* code cleanup

* fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants