Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: statetest json set spec_id #1766

Merged
merged 1 commit into from
Sep 12, 2024
Merged

fix: statetest json set spec_id #1766

merged 1 commit into from
Sep 12, 2024

Conversation

rakita
Copy link
Member

@rakita rakita commented Sep 12, 2024

Statetest if tracing is enabled would run on latest spec and not in one that is set in test.

Copy link
Contributor

Valgrind Results:

==3905== Cachegrind, a cache and branch-prediction profiler
==3905== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==3905== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==3905== Command: target/release/snailtracer
==3905== 
--3905-- warning: L3 cache found, using its data for the LL simulation.
Running snailtracer example!
thread 'main' panicked at /home/runner/work/revm/revm/crates/revm/src/builder.rs:314:39:
called `Option::unwrap()` on a `None` value
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
==3905== 
==3905== I   refs:      1,444,739
==3905== I1  misses:        2,224
==3905== LLi misses:        2,123
==3905== I1  miss rate:      0.15%
==3905== LLi miss rate:      0.15%
==3905== 
==3905== D   refs:        484,610  (311,535 rd   + 173,075 wr)
==3905== D1  misses:        5,622  (  3,922 rd   +   1,700 wr)
==3905== LLd misses:        4,183  (  2,682 rd   +   1,501 wr)
==3905== D1  miss rate:       1.2% (    1.3%     +     1.0%  )
==3905== LLd miss rate:       0.9% (    0.9%     +     0.9%  )
==3905== 
==3905== LL refs:           7,846  (  6,146 rd   +   1,700 wr)
==3905== LL misses:         6,306  (  4,805 rd   +   1,501 wr)
==3905== LL miss rate:        0.3% (    0.3%     +     0.9%  )

@rakita rakita merged commit f57e3e6 into main Sep 12, 2024
27 checks passed
This was referenced Sep 12, 2024
@rakita rakita deleted the rakita/fix/statetesst_spec_id branch September 17, 2024 17:30
@github-actions github-actions bot mentioned this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant