Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: restructure Part2 database crate #1784

Merged
merged 5 commits into from
Sep 18, 2024
Merged

feat: restructure Part2 database crate #1784

merged 5 commits into from
Sep 18, 2024

Conversation

rakita
Copy link
Member

@rakita rakita commented Sep 18, 2024 •
edited
Loading

cargo depgraph --no-default-features --workspace-only | dot -Tpng > graph.png

image

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 18, 2024 •
edited
Loading

Valgrind Results:

==4462== Cachegrind, a cache and branch-prediction profiler
==4462== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==4462== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==4462== Command: target/release/revme bench snailtracer
==4462== 
--4462-- warning: L3 cache found, using its data for the LL simulation.
Running snailtracer example!
elapsed: 1.863090771s
==4462== 
==4462== I   refs:      429,377,938
==4462== I1  misses:          5,448
==4462== LLi misses:          4,163
==4462== I1  miss rate:        0.00%
==4462== LLi miss rate:        0.00%
==4462== 
==4462== D   refs:      205,674,403  (133,128,441 rd   + 72,545,962 wr)
==4462== D1  misses:        346,580  (    203,877 rd   +    142,703 wr)
==4462== LLd misses:        142,399  (      7,266 rd   +    135,133 wr)
==4462== D1  miss rate:         0.2% (        0.2%     +        0.2%  )
==4462== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==4462== 
==4462== LL refs:           352,028  (    209,325 rd   +    142,703 wr)
==4462== LL misses:         146,562  (     11,429 rd   +    135,133 wr)
==4462== LL miss rate:          0.0% (        0.0%     +        0.2%  )

rakita and others added 4 commits September 18, 2024 16:35
@rakita
fix tests
4637d1d
@gitbutler-client
GitButler Workspace Commit
67b374b 
This is a merge commit the virtual branches in your workspace.

Due to GitButler managing multiple virtual branches, you cannot switch back and
forth between git branches and virtual branches easily. 

If you switch to another branch, GitButler will need to be reinitialized.
If you commit on this branch, GitButler will throw it away.

Here are the branches that are currently applied:
 - restructure (refs/gitbutler/restructure)
   branch head: 4637d1d
   - crates/database/src/alloydb.rs
   - crates/revm/Cargo.toml
For more information about what we're doing here, check out our docs:
https://docs.gitbutler.com/features/virtual-branches/integration-branch
@rakita
wip examples
0a9f0dc
@rakita
split examples to standalone crates
77c4a60
@rakita rakita changed the title feat: restructure database crate feat: restructure Part2 database crate Sep 18, 2024
@rakita rakita merged commit fa1e546 into main Sep 18, 2024
27 checks passed
@github-actions github-actions bot mentioned this pull request Sep 18, 2024
Closed
@rakita rakita deleted the rakita/restructure_db branch September 19, 2024 00:11
@github-actions github-actions bot mentioned this pull request Nov 20, 2024
Closed
This was referenced Dec 6, 2024
Closed
Closed
This was referenced Dec 16, 2024
Closed
Open
Open
Open
This was referenced Dec 23, 2024
Open
Closed
Open
Closed
Open
This was referenced Dec 31, 2024
Open
Open
Open
Open
Open
This was referenced Jan 7, 2025
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rakita @gitbutler-client