Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Merge validation/analyzis with Bytecode #1793

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

rakita
Copy link
Member

@rakita rakita commented Sep 23, 2024

Move opcodes and analysis/validation from Interpreter to Bytecode crate. This is preparation for EOF/Bytecode abstraction.

@rakita rakita force-pushed the rakita/restructure_p5_bytecode_analysis branch from e18c0ac to 1237dbc Compare September 23, 2024 15:24
Copy link
Contributor

Valgrind Results:

==4491== Cachegrind, a cache and branch-prediction profiler
==4491== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==4491== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==4491== Command: target/release/revme bench snailtracer
==4491== 
--4491-- warning: L3 cache found, using its data for the LL simulation.
Running snailtracer example!
elapsed: 1.829015971s
==4491== 
==4491== I   refs:      429,380,248
==4491== I1  misses:          4,804
==4491== LLi misses:          4,163
==4491== I1  miss rate:        0.00%
==4491== LLi miss rate:        0.00%
==4491== 
==4491== D   refs:      205,675,161  (133,128,967 rd   + 72,546,194 wr)
==4491== D1  misses:        346,502  (    203,844 rd   +    142,658 wr)
==4491== LLd misses:        142,400  (      7,267 rd   +    135,133 wr)
==4491== D1  miss rate:         0.2% (        0.2%     +        0.2%  )
==4491== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==4491== 
==4491== LL refs:           351,306  (    208,648 rd   +    142,658 wr)
==4491== LL misses:         146,563  (     11,430 rd   +    135,133 wr)
==4491== LL miss rate:          0.0% (        0.0%     +        0.2%  )

@rakita rakita merged commit e7de0bb into main Sep 24, 2024
27 checks passed
@github-actions github-actions bot mentioned this pull request Sep 24, 2024
@DaniPopes DaniPopes deleted the rakita/restructure_p5_bytecode_analysis branch October 17, 2024 12:09
@github-actions github-actions bot mentioned this pull request Nov 20, 2024
This was referenced Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant