Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(database): implement order-independent equality for Reverts #1827

Merged
merged 7 commits into from
Dec 19, 2024

Conversation

hoank101
Copy link
Contributor

@hoank101 hoank101 commented Oct 17, 2024

Fixes #1813

@hoank101
Copy link
Contributor Author

hi @Rjected please help me review it, thank!

hoank101 and others added 3 commits October 18, 2024 16:18
Co-authored-by: rakita <rakita@users.noreply.github.com>
@hoank101 hoank101 requested a review from rakita October 18, 2024 16:08
crates/database/src/states/reverts.rs Outdated Show resolved Hide resolved
crates/database/src/states/reverts.rs Outdated Show resolved Hide resolved
crates/database/src/states/reverts.rs Outdated Show resolved Hide resolved
@hoank101 hoank101 requested a review from Rjected October 19, 2024 02:58
@hoank101
Copy link
Contributor Author

hi @Rjected @rakita please help me review, thank

@hoank101
Copy link
Contributor Author

Hi @rakita can you merge this PR?

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! And thank you for waiting!

@rakita rakita dismissed Rjected’s stale review December 19, 2024 07:30

requested changes were addressed

@rakita rakita merged commit 9455895 into bluealloy:main Dec 19, 2024
27 checks passed
@github-actions github-actions bot mentioned this pull request Dec 19, 2024
@hoank101 hoank101 deleted the refactor-1813 branch December 19, 2024 14:20
royvardhan pushed a commit to royvardhan/revm that referenced this pull request Dec 20, 2024
…ealloy#1827)

* bet

* bet

* bet

* Update crates/database/src/states/reverts.rs

* bet

* bet

* bet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manually impl PartialEq for Reverts
3 participants