Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove analysis bench inner loops #1936

Merged
merged 1 commit into from
Dec 20, 2024
Merged

chore: remove analysis bench inner loops #1936

merged 1 commit into from
Dec 20, 2024

Conversation

DaniPopes
Copy link
Collaborator

Doesn't make a difference when in valgrind

@DaniPopes DaniPopes requested a review from rakita December 20, 2024 16:13
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 20, 2024

CodSpeed Performance Report

Merging #1936 will improve performances by ×6,300

Comparing DaniPopes:codspeed2 (f5ff377) with main (03ea24b)

Summary

⚡ 1 improvements
✅ 6 untouched benchmarks

Benchmarks breakdown

Benchmark main DaniPopes:codspeed2 Change
⚡ analysis 910,107 µs 145.3 µs ×6,300

rakita
rakita approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@rakita rakita merged commit 2ebed31 into bluealloy:main Dec 20, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakita rakita rakita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @rakita