Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add isthmus spec #1938

Merged
merged 1 commit into from
Dec 23, 2024
Merged

feat: add isthmus spec #1938

merged 1 commit into from
Dec 23, 2024

Conversation

leruaa
Copy link
Contributor

@leruaa leruaa commented Dec 20, 2024

Just adding HOLOCENE and ISTHMUS to OpSpecId.

It will be needed for ethereum-optimism/specs#373, and more precisely I would need it to be able to handle Isthmus in op-reth.

Closes #1874

Copy link

codspeed-hq bot commented Dec 20, 2024

CodSpeed Performance Report

Merging #1938 will not alter performance

Comparing leruaa:add-isthmus-spec (32dfc3a) with main (03ea24b)

Summary

✅ 7 untouched benchmarks

Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thank you

@rakita rakita merged commit 237bb1c into bluealloy:main Dec 23, 2024
28 checks passed
@github-actions github-actions bot mentioned this pull request Dec 23, 2024
@rakita
Copy link
Member

rakita commented Dec 23, 2024

Reth still uses release/v51 branch and is unsure if integration with main will happen before istmus. ISTHMUS needs to be added there

@leruaa
Copy link
Contributor Author

leruaa commented Dec 24, 2024

@rakita Isn't reth on release/v50 branch? Trying to patch with release/v51 I hit changes related to Pectra

@github-actions github-actions bot mentioned this pull request Dec 24, 2024
@rakita
Copy link
Member

rakita commented Dec 24, 2024

@rakita Isn't reth on release/v50 branch? Trying to patch with release/v51 I hit changes related to Pectra

It uses release/v50, but I will bump release/v51 soon, so new changes should be there.

It is next release after v50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Isthmus spec (OP)
2 participants