Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename OptimismHaltReason -> OpHaltReason #2042

Merged
merged 1 commit into from
Jan 31, 2025
Merged

chore: rename OptimismHaltReason -> OpHaltReason #2042

merged 1 commit into from
Jan 31, 2025
+23 −28

Conversation

klkvr
Copy link
Collaborator

@klkvr klkvr commented Jan 30, 2025

No description provided.

mattsse
mattsse approved these changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this follows the convention that we established across all of the op crates and (most of) reth

Op short for opstack

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 30, 2025

CodSpeed Performance Report

Merging #2042 will not alter performance

Comparing klkvr/op-halt-reason (e064a83) with main (62119ca)

Summary

✅ 8 untouched benchmarks

rakita
rakita approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@rakita rakita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intended to this for a while now. lgtm

@rakita rakita merged commit 5407d7a into main Jan 31, 2025
28 checks passed
@github-actions github-actions bot mentioned this pull request Feb 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rakita rakita rakita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@klkvr @rakita @mattsse