-
Notifications
You must be signed in to change notification settings - Fork 587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Optimism execution changes #682
Conversation
fe9bc08
to
a31c31c
Compare
fix: Flatten optimism hoisted tx fields
fix: Refactor l1 cost and mint computations
feat: Refactor gas usage
chore: upstream sync
Think this is ready for a another round of review. What are your normal standards for tests @rakita? @refcell and I looked into integrating with t8n and t9n in order to generate state tests for OP, but that may be a bit further out. Glad to attempt to hook this version into Feel free to let us know if there is anything we can change as well 😄 |
Merge REVM upgrades
chore: upstream sync
Would really really appreciate another round of review here |
Introduce call return handler
feat: Handler
Oprevm merge to main repo
remove USE_GAS from handlers
fix: quick no-conflict upstream sync
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! One nit comment.
Co-authored-by: rakita <rakita@users.noreply.github.com>
sync: quick upstream sync - no conflicts
fix: param mutability
Overview
Implements Optimism's execution changes into
revm
behind theoptimism
feature flag. These changes enable native Optimism execution changes inop-reth
,foundry
,anvil
, and other projects building on top ofrevm
.Goal
With the
optimism
feature flag enabled, a new configuration option is exposed that allows for enabling Optimism's execution changes at runtime. This is so that tools such as Foundry can swap between regular Ethereum execution and Optimism execution as needed (i.e. for multichain fork testing).revm
's regular logic should be unaltered if either theoptimism
cfg option isfalse
or theoptimism
feature flag is not enabled.New Hardforks
Bedrock
(Ethereum Base:Merge
)Regolith
(Base:Bedrock
)TODO
TxEnv
fields withinrevm-primitives
.Some
mint field.optimism
configuration flag is enabled.L1Block
contract.Future
optimism
cfg option add when theoptimism
feature flag is enabled but theoptimism
cfg option is not? For example, in order forfoundry
to swap betweenoptimism
andethereum
execution modes, the regular release build will have to enable theoptimism
feature flag onrevm
. Does the runtime branching significantly slow down execution for the majority of tests which are not on OP?