Bugfix/ 매치스크린 에러 해결 및 리펙토링 #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
설명
매치스크린 에러 해결 및 리펙토링
변경 사항
변경 1
기존 매칭 기능에서 발생할 수 있는 여러 에러 패턴 대응 로직을 추가
변경 2
유저가 좋아요, 즐겨찾기 결과를 알 수 있도록 sanckbar 위젯으로 안내메세지를 출력
변경 3
매칭 로직 리펙토링 : 단일책임원칙을 적용 match provider 안 함수를 작은 단위로 분리
변경 4
voiceoutput, voiceOutput 폴더 변경?
체크리스트
< 체크리스트 항목을 확인해 주세요. >
make커맨드를 터미널에서 실행하였는가?참조
voiceoutput, voiceOutput 폴더 관련 git 문제로 voiceOutput 폴더만 push 합니다.
영향은 받겠지만 수정된 부분이 적은 만큼 이전 커밋 코드를 이용해서 쉽게 복구 가능할 것 같습니다.