Skip to content

Commit

Permalink
Update performance IPH configs to match Finch
Browse files Browse the repository at this point in the history
Changes should reflect the changes being made in cl/519149402

Bug: 1427457
Change-Id: I7f100ecb8ce47aeb1bad5c9e04554a610a8481ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4370622
Reviewed-by: Dana Fried <dfried@chromium.org>
Commit-Queue: Alison Gale <agale@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1121967}
  • Loading branch information
Alison Gale authored and Chromium LUCI CQ committed Mar 24, 2023
1 parent 22196e2 commit 3c027aa
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions components/feature_engagement/public/feature_configurations.cc
Original file line number Diff line number Diff line change
Expand Up @@ -154,9 +154,9 @@ absl::optional<FeatureConfig> GetClientSideFeatureConfig(
absl::optional<FeatureConfig> config = FeatureConfig();
config->valid = true;
config->availability = Comparator(ANY, 0);
config->session_rate = Comparator(ANY, 0);
config->session_rate = Comparator(EQUAL, 0);
config->trigger = EventConfig("battery_saver_info_triggered",
Comparator(EQUAL, 0), 360, 360);
Comparator(LESS_THAN, 3), 360, 360);
config->used =
EventConfig("battery_saver_info_shown", Comparator(EQUAL, 0), 7, 360);
return config;
Expand All @@ -166,11 +166,11 @@ absl::optional<FeatureConfig> GetClientSideFeatureConfig(
absl::optional<FeatureConfig> config = FeatureConfig();
config->valid = true;
config->availability = Comparator(ANY, 0);
config->session_rate = Comparator(ANY, 0);
// Show the promo once a year if the page action chip was not opened
config->session_rate = Comparator(EQUAL, 0);
// Show the promo up to 3 times if the page action chip was not opened
// within the last week
config->trigger = EventConfig("high_efficiency_info_trigger",
Comparator(EQUAL, 0), 360, 360);
Comparator(LESS_THAN, 3), 360, 360);
config->used =
EventConfig("high_efficiency_info_shown", Comparator(EQUAL, 0), 7, 360);
return config;
Expand All @@ -180,10 +180,10 @@ absl::optional<FeatureConfig> GetClientSideFeatureConfig(
absl::optional<FeatureConfig> config = FeatureConfig();
config->valid = true;
config->availability = Comparator(ANY, 0);
config->session_rate = Comparator(ANY, 0);
// Show the promo max 3 times, once per day.
config->session_rate = Comparator(EQUAL, 0);
// Show the promo max 3 times, once per week.
config->trigger = EventConfig("high_efficiency_prompt_in_trigger",
Comparator(LESS_THAN, 1), 1, 360);
Comparator(LESS_THAN, 1), 7, 360);
// This event is never logged but is included for consistency.
config->used = EventConfig("high_efficiency_prompt_in_used",
Comparator(EQUAL, 0), 360, 360);
Expand Down

0 comments on commit 3c027aa

Please sign in to comment.