Skip to content

Commit

Permalink
Roll nearby-connections from 32e6fc3c4262 to 41ba8c8a14a8 (1 revision)
Browse files Browse the repository at this point in the history
https://chromium.googlesource.com/external/github.com/google/nearby-connections.git/+log/32e6fc3c4262..41ba8c8a14a8

2022-10-25 hais@google.com Convert `#include <xstring>` to `#include <string>` in nearby files.
> `<xstring>` is the MSVC internal implementation file for string. This makes it contingent on the MSVC STL.
>
> `<string>` provides the same declarations, but does not expose the MSVC-specific implementation details. This implementation is guaranteed to meet the C++ standard exactly.
>
> This change updates includes of `<xstring>` to be includes of `<string>`.
>
> PiperOrigin-RevId: 483696244
>

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/nearby-connections-chromium
Please CC chromeos-cross-device-eng+autoroll@google.com,jonfan@google.com,nearby-chromeos-eng+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-nearby-chrome-fyi
Bug: None
Tbr: chromeos-cross-device-eng+autoroll@google.com,jonfan@google.com,nearby-chromeos-eng+autoroll@google.com
Change-Id: Id6104816438598c61bb8990784672c3b9923492a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3978292
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1063436}
  • Loading branch information
chromium-internal-autoroll authored and Chromium LUCI CQ committed Oct 25, 2022
1 parent 37c8fa4 commit 4752220
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,7 @@ vars = {
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling nearby
# and whatever else without interference from each other.
'nearby_revision': '32e6fc3c42622f30fad469d6ed2a5ac3700b1ec0',
'nearby_revision': '41ba8c8a14a83cc9a7eda5583bf042d0cb873a28',
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling securemessage
# and whatever else without interference from each other.
Expand Down
2 changes: 1 addition & 1 deletion third_party/nearby/README.chromium
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Name: Nearby Connections Library
Short Name: Nearby
URL: https://github.com/google/nearby
Version: 32e6fc3c42622f30fad469d6ed2a5ac3700b1ec0
Version: 41ba8c8a14a83cc9a7eda5583bf042d0cb873a28
License: Apache 2.0
License File: LICENSE
Security Critical: yes
Expand Down

0 comments on commit 4752220

Please sign in to comment.