forked from chromium/chromium
-
-
Notifications
You must be signed in to change notification settings - Fork 17
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[M106] Files app: Fix new breadcrumbs with Shared with me
"Shared with me" uses the drive search code. The new breadcrumbs + change directory using the Store was in a infinite loop when trying to clear the search during the "change directory". This CL fixes by only try to clear the search if the store has a search. Also tested the fix manually in the DUT. (cherry picked from commit f40efc2) Test: browser_tests --gtest_filter="*breadcrumbNavigateBackToSharedWithMe*" Bug: 1354004 Change-Id: I1f517e01587b31cd2f0f73ee3e009a2d5d559b95 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3841134 Commit-Queue: Ben Reich <benreich@chromium.org> Reviewed-by: Ben Reich <benreich@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1036945} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3848901 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/5249@{#28} Cr-Branched-From: 4f7bea5-refs/heads/main@{#1036826}
- Loading branch information
Luciano Pacheco
authored and
Chromium LUCI CQ
committed
Aug 23, 2022
1 parent
50c4f41
commit b29a892
Showing
4 changed files
with
43 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters