Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Twitter inserts on golfmonthly.com don't work... #54

Closed
pjpreilly opened this issue Mar 19, 2022 · 8 comments
Closed

Twitter inserts on golfmonthly.com don't work... #54

pjpreilly opened this issue Mar 19, 2022 · 8 comments

Comments

@pjpreilly
Copy link

pjpreilly commented Mar 19, 2022 •
edited
Loading

On latest canary osx 10.7.5 ...should look like....

https://www.golfmonthly.com/news/watch-schwartzel-throws-club-then-makes-slam-dunk-194-yard-hole-out

Screenshot 2022-03-19 12 55 04 PM

...but doesn't render...
@Wowfunhappy
Copy link

Wowfunhappy commented Mar 19, 2022 •
edited
Loading

Looks like this isn't a Chromium Legacy issue. The same issue exists in the equivalent version of official Chrome Canary in High Sierra.

@pjpreilly
Copy link
Author

Wow...I tested on Cloudready & it worked fine on the same macbook 4,1 hardware....

@Wowfunhappy
Copy link

Does Cloudready run build 983057 of Chromium Canary?

@pjpreilly
Copy link
Author

ChromeOS Flex runs Version 101.0.4920.0 (Official Build) Lacros (64-bit). & it works on an old macbook air.
Cloudready is on v96.0.4664.202 & it works on the macbook 4,1.

@pjpreilly
Copy link
Author

& FWIW it works on Firefox on osx Big Sur but not on stable Google Chrome there...

@Wowfunhappy
Copy link

ChromeOS Flex runs Version 101.0.4920.0 (Official Build) Lacros (64-bit). & it works on an old macbook air.
Cloudready is on v96.0.4664.202 & it works on the macbook 4,1.

Right, so those are different. From my testing, this problem is specific to the last few builds of Chrome Canary.

Regardless, this isn't a Chromium Legacy bug. It'll be fixed when Google fixes it.

@pjpreilly
Copy link
Author

Fixed by somebody...as of the latest Canary & probably a bit earlier...

@Wowfunhappy
Copy link

Wowfunhappy commented Mar 30, 2022 •
edited
Loading

Thanks for closing these old issues, I'm a little worried that the next time Bluebox has a chance to check Github, he'll be freaked out by the slew of new issues for things that have actually been fixed anyway. I try to make his life easier where I can.

blueboxd pushed a commit that referenced this issue Jun 22, 2022
@yaoxiachromium
[Merge to M103] [shared storage] rename runXXXOperation() and switch …
20d1d06 
…to a single register() function

- rename runURLSelectionOperation() to selectURL()
- rename runOperation() to run()
- combine registerXXXOperation into a single register() function:
migrate the `operation_definition_map_` map and registration function
from `UnnamedOperationHandler` and `UrlSelectionOperationHandler` to
`SharedStorageWorkletGlobalScope`, and only keep a reference of the maps
in the two handlers.

This CL updates the web & user facing functions, and will be merged
to M103.

A future CL will update other references (i.e. C++ functions, comments)
in rest of the code base, and that will be in M104 after most M103
targets are done.

Updated explainer:
https://github.com/pythagoraskitty/shared-storage/blob/main/README.md

(cherry picked from commit a10fe19)

Bug: 1325112
Change-Id: Id857d35e99b74b40e3f219ac00a36622de002dd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3645133
Reviewed-by: Cammie Smith Barnes <cammie@chromium.org>
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Commit-Queue: Yao Xiao <yaoxia@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1003398}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3651768
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Yao Xiao <yaoxia@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5060@{#54}
Cr-Branched-From: b83393d-refs/heads/main@{#1002911}
blueboxd pushed a commit that referenced this issue Aug 31, 2022
@vmpstr
Revert "[a11y-during-render] Call AddImageAnnotations from within Blink"
09bd2f6 
This reverts commit d70b84e.

Reason for revert: crbug.com/1346271 crbug.com/1346174 crbug.com/1346175

Original change's description:
> [a11y-during-render] Call AddImageAnnotations from within Blink
>
> Why: moves more of the serialization code out of BlinkAXTreeSource,
>   unblocking further refactoring. It also increases performance by
>   reducing copies and enabling use of the display lock memoizer.
>
> Why not move AXImageAnnotator entirely to Blink: I tried it, and it
> was going to be a *ton* of work given how much string manipluation
> is in there. Since there are not a whole lot of images on pages, it
> didn't seem worth it to avoid passing around a few more WebAXObjects.
>
> AX-Relnotes: n/a
> Bug: 1068668
>
> Change-Id: I8e2687b3a0ce338b2149ae256f7d5a4e13183d7d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3767642
> Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
> Reviewed-by: David Tseng <dtseng@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1026420}

(cherry picked from commit 5f49c78)

Bug: 1068668, 1346271, 1346174, 1346175
Change-Id: I76ee73a1b49cdb7c1d95de3e53e07d6647f2c1e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3783136
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Vladimir Levin <vmpstr@chromium.org>
Owners-Override: Philip Rogers <pdr@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1027993}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3782097
Owners-Override: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/5195@{#54}
Cr-Branched-From: 7aa3f07-refs/heads/main@{#1027018}
blueboxd pushed a commit that referenced this issue Sep 29, 2022
@dbaron
Revert "Cache whether scroll animating element was removed by commit."
3790553 
This reverts commit f5512df.

Reason for revert: performance regression scrolling on gmail.

Original change's description:
> Cache whether scroll animating element was removed by commit.
>
> This change:
>
> * notifies the AnimationHost whether or not the scroll animating element
>   is currently animating, and
>
> * caches that the scroll animation element has been removed by commit,
>   in case the animation restarts.
>
> Fixed: 1341219
> Bug: 900241, 1347679
> Change-Id: Ie8d154bdd430031480e32a943bcd71dd2ab21313
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3813083
> Reviewed-by: Robert Flack <flackr@chromium.org>
> Commit-Queue: Robert Flack <flackr@chromium.org>
> Auto-Submit: David Baron <dbaron@chromium.org>
> Commit-Queue: David Baron <dbaron@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1033685}

(cherry picked from commit 1e67c36)

Bug: 900241, 1347679
Change-Id: I9f95b9a8b254beee1ffe763524606e4497d4ce05
Fixed: 1354807
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3846211
Auto-Submit: David Baron <dbaron@chromium.org>
Commit-Queue: David Baron <dbaron@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1038020}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3846194
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5249@{#54}
Cr-Branched-From: 4f7bea5-refs/heads/main@{#1036826}
blueboxd pushed a commit that referenced this issue Nov 30, 2022
[M108][UPM] Delay google-mobile-services-passwords flag expiration
bf93088 
The Unified Password Manager rollout on Android is ongoing, this flag
is in use. Added myself as owner as fhorschig@ is not focused on this
project.

google-mobile-services-passwords-error-messages flag expiration was
aligned with other UPM-related flags.

(cherry picked from commit 56b81a6)

Bug: 1374786
Change-Id: I95abf5432ba22cab33d358eae336a168846282b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3959734
Auto-Submit: Maxim Anufriev <maxan@google.com>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Maxim Anufriev <maxan@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1059881}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3963055
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5359@{#54}
Cr-Branched-From: 27d3765-refs/heads/main@{#1058933}
blueboxd pushed a commit that referenced this issue Feb 8, 2023
@joedow-42
Fix low BWE issues in multi-stream mode
8e7050b 
We've been seeing very low BWE values (2.5MBps or lower) when using
multiple video streams which leads to a very poor user experience
such as very low framerates, poor frame quality, and frequent pauses
when interacting with the remote machine).

This issue was odd in that it seemed to occur frequently for some users
but others did not seem to encounter it.

I tracked the issue down to an inconsistency in how the min/max
bitrates were being applied to the video RtpSenders. Basically if the
connection used Relay as the first transport route and then switched
to STUN/Direct later, the bitrates were applied to the peer connection
but not the RtpSenders.

I moved some duplicated code into a single method to 'UpdateBitrates'
which replaces the duplicated code so bitrates are set/updated in a
consistent fashion which appears to solve the low BWE issue.

(cherry picked from commit 9da7467)

Bug: b:263256236,1403094
Change-Id: I8993388ec23b59f7b14aaa4dca7da507dc2a3046
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4121393
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Auto-Submit: Joe Downing <joedow@chromium.org>
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1086181}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4123370
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/branch-heads/5481@{#54}
Cr-Branched-From: 130f3e4-refs/heads/main@{#1084008}
blueboxd pushed a commit that referenced this issue Mar 7, 2023
Roll AFDO from 111.0.5558.0_rc-r1-merged to 111.0.5563.7_rc-r1-merged
b285af6 
This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file go/crostc-bug.

Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/afdo-chromium-beta
Please CC c-compiler-chrome@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Chromium Beta Branch: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Tbr: c-compiler-chrome@google.com
Change-Id: I121fb48a4c1ce094106def736b3417267c33bf7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4208492
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5563@{#54}
Cr-Branched-From: 3ac59a6-refs/heads/main@{#1097615}
blueboxd pushed a commit that referenced this issue Apr 14, 2023
Roll v8 11.2 from 56a783773001 to 9c6d767b3121 (2 revisions)
7c3ef15 
https://chromium.googlesource.com/v8/v8.git/+log/56a783773001..9c6d767b3121

2023-02-28 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Version 11.2.214.4
2023-02-28 mlippautz@chromium.org Merged: Combined revert for string transitions 2/2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/v8-chromium-release-0
Please CC liviurau@google.com,v8-waterfall-sheriff@grotations.appspotmail.com,vahl@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in v8 11.2: https://bugs.chromium.org/p/v8/issues/entry
To file a bug in Chromium m112: https://bugs.chromium.org/p/chromium/issues/entry

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Bug: chromium:1418283
Tbr: v8-waterfall-sheriff@grotations.appspotmail.com
Change-Id: I496c505dd8571264b52b66f1186dc5aaa29a6036
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4297774
Commit-Queue: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Bot-Commit: Chrome Release Autoroll <chromium-release-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5615@{#54}
Cr-Branched-From: 9c6408e-refs/heads/main@{#1109224}
blueboxd pushed a commit that referenced this issue May 9, 2023
[PCCT-SideSheet] Calculate PCCT type no 3P check
43be564 
(cherry picked from commit 113ba60)

Bug: 1427246
Change-Id: I5e14448748f73bd0c8c5a38d1df5eb8c8d66b6fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4370863
Commit-Queue: Zach Katz <katzz@google.com>
Reviewed-by: Kevin Grosu <kgrosu@google.com>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Cr-Original-Commit-Position: refs/heads/main@{#1121903}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4374070
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/5672@{#54}
Cr-Branched-From: 5f2a724-refs/heads/main@{#1121455}
blueboxd pushed a commit that referenced this issue May 27, 2023
@Arcank
[5735] Measure the time spent opening an existing tab
6f8856f 
This CL adds a time histogram to measure how long it took for the user
to select an existing tab in the tab switcher. If the user opens a new
tab or closes the tab switcher, it is not recorded.

(cherry picked from commit 285d8d0)

Fixed: 1440186
Change-Id: I1b312978444be13a96796d8665941781dc57738c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4482554
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Louis Romero <lpromero@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1136465}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4489066
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Auto-Submit: Louis Romero <lpromero@google.com>
Cr-Commit-Position: refs/branch-heads/5735@{#54}
Cr-Branched-From: 2f562e4-refs/heads/main@{#1135570}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Wowfunhappy @pjpreilly