Fix recordings dir reported not writable (#620) #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue bluecherrydvr#620 arises because the dir exists, is owned by bluecherry:bluecherry, but is by default writable only by owning user, but not the owning group. Fix this here in docker image building code. root@df79d5606903:~# sudo -u www-data php -r "echo is_writable('/var/lib/bluecherry/recordings') ? 'writable' : 'not writable';"; echo not writable root@df79d5606903:~# sudo -u www-data touch /var/lib/bluecherry/recordings/www-data.was.here touch: cannot touch '/var/lib/bluecherry/recordings/www-data.was.here': Permission denied root@df79d5606903:~# id uid=0(root) gid=0(root) groups=0(root) root@df79d5606903:~# id www-data uid=33(www-data) gid=33(www-data) groups=33(www-data),4(adm),20(dialout),29(audio),44(video),999(bluecherry) root@df79d5606903:~# ls -l /var/lib/bluecherry/recordings -d drwxr-xr-x 2 bluecherry bluecherry 4096 Nov 24 00:36 /var/lib/bluecherry/recordings root@df79d5606903:~# chmod g+w /var/lib/bluecherry/recordings root@df79d5606903:~# ls -l /var/lib/bluecherry/recordings -d drwxrwxr-x 2 bluecherry bluecherry 4096 Nov 24 00:36 /var/lib/bluecherry/recordings root@df79d5606903:~# sudo -u www-data touch /var/lib/bluecherry/recordings/www-data.was.here root@df79d5606903:~# sudo -u www-data php -r "echo is_writable('/var/lib/bluecherry/recordings') ? 'writable' : 'not writable';"; echo writable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduced on an Ubuntu 22.04 LTS virtual machine.
All three fixes are necessary.
Test in progress for the last fix - I am not certain myself.