Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mailer.php #640

Merged
merged 3 commits into from
Jan 31, 2024
Merged

Update mailer.php #640

merged 3 commits into from
Jan 31, 2024

Conversation

curtishall
Copy link
Member

Should fix #639

@curtishall curtishall marked this pull request as ready for review January 17, 2024 13:23
Comment on lines 206 to 204
if (!$rules){
exit('I: No matching rules');

# Proceed only if rules are found
if ($rules) {
# If there are no rules (yet) don't display anything bad.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Negation disappeared? I would expect it to be

if (!$rules) {
    # If there are no rules (yet) don't display anything bad.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed

Changed to Negation
www/lib/mailer.php Outdated Show resolved Hide resolved
@curtishall curtishall merged commit 33880ce into master Jan 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove warnings in mailer.php
2 participants