Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding storage locations and setup permissions #642

Merged
merged 14 commits into from
Jan 16, 2024

Conversation

curtishall
Copy link
Member

No description provided.

@curtishall curtishall changed the title Update check_dir_permission.sh [WIP] Update check_dir_permission.sh Jan 1, 2024
curtishall and others added 10 commits December 31, 2023 21:05
Remove duplicate text when adding storage locations, change STRAGE_HEADER TO STORAGE_HEADER
Change define STRAGE_HEADER to STORAGE_HEADER
Copy update_subdomain_certs.sh
This reverts commit e071449.
Was STRAGE_HEADER
@curtishall curtishall changed the title [WIP] Update check_dir_permission.sh [WIP] Allow adding storage locations and setup permissions Jan 9, 2024
Copy link
Contributor

@andrey-utkin andrey-utkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please clarify the intended effect of the changes felt by the user?

I tested this in runtime and the UI fails to add a location. I am yet to compare this with a build off master branch.

www/ajax/storagecheck.php Show resolved Hide resolved
@curtishall
Copy link
Member Author

@andrey-utkin Code works on https://192.168.86.66:7001/storage (focal, latest from this branch)

Can you test there? Perhaps we have a permission issue with the script?

Change install path location for check_dir_permission.sh
Copy link
Contributor

@andrey-utkin andrey-utkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@curtishall curtishall changed the title [WIP] Allow adding storage locations and setup permissions Allow adding storage locations and setup permissions Jan 16, 2024
@curtishall curtishall marked this pull request as ready for review January 16, 2024 00:03
@andrey-utkin andrey-utkin merged commit c067a1e into master Jan 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants