Change from lazy media storage cleanup to eager #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, if there was any storage location below max use threshold, the cleanup was skipped. This might cause problem described in bluecherrydvr#656 : as long as one location has space, others might fill up if used by other processes. The default location, /var/lib/bluecherry/recordings/ is usually on the system rootfs, where many services' and users' activities contribute to increasing the filesystem space used. Now, the media cleanup happens if any of the storage locations is over the threshold.
|
Tested, works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, if there was any storage location below max use threshold, the cleanup was skipped. This might cause problem described in #656 : as long as one location has space, others might fill up if used by other processes. The default location, /var/lib/bluecherry/recordings/ is usually on the system rootfs, where many services' and users' activities contribute to increasing the filesystem space used.
Now, the media cleanup happens if any of the storage locations is over the threshold.