Fix video snapshots saving #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
media_writer::scale_frame() converts the frame to a JPEG-compatible
pixel format, but it doesn't carry over all the frame metadata like
format, and picture dimensions. This is the apparent reason why video
snapshots don't work. This problem has been reported by many users after
the 3.1.2 release, which brought the upgrade of bundled ffmpeg to
6.1.1 from 4.2.1.
This change has been tested.
The problem shows up in the log like this:
I(1/camera_name): Making a snapshot
E(1/camera_name): avcodec_send_frame: snapshot encoding failed: Invalid argument
E(1/camera_name): failed to write snapshot frame
E(1/camera_name): Feeding snapshot decoder failed
E(1/camera_name): Failed to make snapshot
andrey-utkin
force-pushed
the
fix-snapshots
branch
from
96f3f2c to
fae47f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
media_writer::scale_frame() converts the frame to a JPEG-compatible pixel format, but it doesn't carry over all the frame metadata like format, and picture dimensions. This is the apparent reason why video snapshots don't work. This problem has been reported by many users after the 3.1.2 release, which brought the upgrade of bundled ffmpeg to 6.1.1 from 4.2.1.
This change has been tested.
The problem shows up in the log like this: