Improve timestamps handling at recording muxing #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifically: - Restart recording on timestamping problems - Reset last_mux_dts[] on media_writer::close() - consistently use AV_NOPTS_VALUE as "NULL" for last_mux_dts - don't update last_mux_dts to a bad one which isn't muxed Reliability regressions were reported on certain setups attributed to changes in 3.1.2 and 3.1.6. One scenario in which problems arise is: an HDMI-to-RTSP encoder is connected as a device to Bluecherry server, and the upstream video source connected to the encoder is switched off and later back on. This commit solves the issues for the scenario which we reproduced in our lab.
curtishall
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically:
Reliability regressions were reported on certain setups attributed to changes in 3.1.2 and 3.1.6.
One scenario in which problems arise is: an HDMI-to-RTSP encoder is connected as a device to Bluecherry server, and the upstream video source connected to the encoder is switched off and later back on.
This commit solves the issues for the scenario which we reproduced in our lab.