-
Notifications
You must be signed in to change notification settings - Fork 853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update AudioCache explanation, migration guide, replace package READMEs #1457
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm hoping github will understand a symlink
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like GH is showing it fine also for root, or do you have a special case in mind?
https://github.com/bluefireteam/audioplayers/tree/gustl22/update-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should update the Support section based on the flame repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated, but don't know if you want the badge also, and if want to credit community somewhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to escape single underscore? I don't think I've ever seem that on other markdowns
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saw it here, but don't think it's needed: https://raw.githubusercontent.com/flutter/packages/main/packages/video_player/video_player_avfoundation/README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@luanpotter @spydon I also now updated some of the contributing stuff (regarding the lack docs for setting up Melos, which is quite important I think). I know that there could be updated much more, like in flame. But I also think every new passage needs to be maintained. So I'd rather keep it simple and leave out the redundant stuff. |
Description
audioplayers
package (chore: Use license file directly instead of symlinks #1433,pub publish
is not picking symbolic links dart-lang/pub#2699)Copying Symlink targets for release should not be necessary anymore.
Checklist
fix:
,feat:
,docs:
,chore:
etc).///
, where necessary.Breaking Change