Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use license file directly instead of symlinks #1433

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

spydon
Copy link
Member

@spydon spydon commented Mar 13, 2023

Description

Since you can't publish a package with a symlink referring outside of the package this turns all the LICENSE symlinks to real files.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs:, chore: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in example.

Breaking Change

  • No, this is not a breaking change.

Related Issues

@spydon spydon requested review from Gustl22 and luanpotter March 13, 2023 17:59
@spydon spydon enabled auto-merge (squash) March 13, 2023 17:59
@Gustl22
Copy link
Collaborator

Gustl22 commented Mar 13, 2023

@spydon are you sure it doesn't work without the script?
But don't know if it concerns the repo or the package...
dart-lang/pub#2193

Edit: I'm wrong dart-lang/pub#2699

@spydon
Copy link
Member Author

spydon commented Mar 13, 2023

@spydon are you sure it doesn't work without the script?
But don't know if it concerns the repo or the package...
dart-lang/pub#2193

Edit: I'm wrong dart-lang/pub#2699

I think it possibly works to publish from Windows, but that's just because symlinks works differently there.

For the license file I don't think it matters much anyways since it never changes.

@Gustl22
Copy link
Collaborator

Gustl22 commented Mar 14, 2023

We should also add separate READMEs for each package, as they are symlinks, too, like done with Flutter packages. But we can do this in a separate Merge Request, if desired.

@spydon spydon merged commit 82f16c3 into main Mar 14, 2023
@spydon spydon deleted the spydon/licence-not-symlinks branch March 14, 2023 09:18
Gustl22 added a commit that referenced this pull request Apr 5, 2023
… READMEs (#1457)

# Description

* update AudioCache explanation (closes #1256)
* replace package README.md symlinks with files, and switched main
README file to `audioplayers` package (#1433,
dart-lang/pub#2699)
* update migration guide to use Changelog
* update contribution guide
* update parity table
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants