Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(example): update app icons #1417

Merged
merged 10 commits into from
Feb 9, 2023
Merged

feat(example): update app icons #1417

merged 10 commits into from
Feb 9, 2023

Conversation

Gustl22
Copy link
Collaborator

@Gustl22 Gustl22 commented Feb 9, 2023

Description

I created a logo for our library (or mostly for the exapmle app) in style of the Flutter logo. Idk if you more want sth that matches the Flame logo. E.g. a burning note (?).
Or we can change it again, if we crave for sth better :)

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs:, chore: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in example.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

@Gustl22 Gustl22 marked this pull request as ready for review February 9, 2023 10:00
@Gustl22 Gustl22 requested review from spydon and luanpotter February 9, 2023 12:10
@spydon
Copy link
Member

spydon commented Feb 9, 2023

Woooow, looks great!
I don't think it has to look like Flame since it is completely separate from flame. :)

Copy link
Member

@erickzanardo erickzanardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! You should put it on the readme too :D

@spydon
Copy link
Member

spydon commented Feb 9, 2023

Love it! You should put it on the readme too :D

Agree! Maybe in a similar fashion like we do with the centered Flame logo? 😍

@Gustl22 Gustl22 marked this pull request as draft February 9, 2023 16:34
Copy link
Member

@renancaraujo renancaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@Gustl22
Copy link
Collaborator Author

Gustl22 commented Feb 9, 2023

Unfortunately CSS styling is not a thing in GH, so I have to add the text in the logo itself. I tried many combinations, and as the name is that long, it looks weird to put it under the icon, so I put it next to it like done on Flutter itself.
You can preview README here, as the link to the logo is not yet existant (only after merging) to provide absolute paths due to the monorepos subpackages.

Compact Horizontal Vertical
logo_ap_compact logo_ap_horizontal logo_ap_vertical

@Gustl22 Gustl22 marked this pull request as ready for review February 9, 2023 18:08
@spydon
Copy link
Member

spydon commented Feb 9, 2023

Unfortunately CSS styling is not a thing in GH, so I have to add the text in the logo itself. I tried many combinations, and as the name is that long, it looks weird to put it under the icon, so I put it next to it like done on Flutter itself. You can preview README here, as the link to the logo is not yet existant (only after merging) to provide absolute paths due to the monorepos subpackages.

Nice, the first one is my favourite!
Make sure to store both the logo separately and the logo with text in the repo so that we can use them as fitting in different contexts.

@erickzanardo
Copy link
Member

First one is my favorite as well!

@Gustl22
Copy link
Collaborator Author

Gustl22 commented Feb 9, 2023

For me personally or from Design perspective I think the second variant is best for the README header as it states the package name more clearly and possibly bringing less confusion to the users.
But I'm also happy to change it to the first variant! Won't make much of a difference in the end. I can add the other ones as well for completeness. I always provide vector files, which can be manipulated as desired.

Only for clearing the terms:
icon - the icon / brand itself
logo - the brand mostly with text

@Gustl22
Copy link
Collaborator Author

Gustl22 commented Feb 9, 2023

Changed to compact logo. Looks quite clear too :)

@Gustl22 Gustl22 enabled auto-merge (squash) February 9, 2023 19:07
@Gustl22 Gustl22 merged commit ac35df8 into main Feb 9, 2023
@Gustl22 Gustl22 deleted the gustl22/logo branch February 9, 2023 20:00
@luanpotter
Copy link
Member

OMG this is so awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants