Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): make start and resume async #1436

Merged
merged 1 commit into from
Mar 17, 2023
Merged

fix(web): make start and resume async #1436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/audioplayers_web/lib/audioplayers_web.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ class AudioplayersPlugin extends AudioplayersPlatform with StreamsInterface {

@override
Future<void> resume(String playerId) async {
getOrCreatePlayer(playerId).resume();
await getOrCreatePlayer(playerId).resume();
}

@override
Expand Down
8 changes: 4 additions & 4 deletions packages/audioplayers_web/lib/wrapped_player.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,20 +127,20 @@ class WrappedPlayer {
playerPlaySubscription = null;
}

void start(double position) {
Future<void> start(double position) async {
isPlaying = true;
if (currentUrl == null) {
return; // nothing to play yet
}
if (player == null) {
recreateNode();
}
player?.play();
await player?.play();
player?.currentTime = position;
}

void resume() {
start(pausedAt ?? 0);
Future<void> resume() async {
await start(pausedAt ?? 0);
}

void pause() {
Expand Down