Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): Avoid calling onDuration on position event (closes #136) #1460

Merged
merged 2 commits into from
Apr 6, 2023

Conversation

Gustl22
Copy link
Collaborator

@Gustl22 Gustl22 commented Apr 5, 2023

Description

Unlike on other platforms, onDuration is constantly called on Android. This PR avoids calling onDuration on every position event.
OnDuration is still once called with the correct duration after having prepared the source.

Checklist

  • The title of my PR starts with a [Conventional Commit] prefix (fix:, feat:, docs:, chore: etc).
  • I have read the [Contributor Guide] and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in [example].

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

Closes #136

@Gustl22 Gustl22 merged commit 6cfb375 into main Apr 6, 2023
@Gustl22 Gustl22 deleted the gustl22/136-avoid-calling-onDuration branch April 6, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onDurationChanged called constantly on Android
2 participants