Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(android): Upgrade androidx.core:core-ktx, restore support for AGP7 #1590

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

Gustl22
Copy link
Collaborator

@Gustl22 Gustl22 commented Jul 31, 2023

Description

Revert the update of androidx.core:core-ktx version from 1.9.0 to 1.10.1 in #1577. The update was originally proposed by the IDE, but this requires AGP 8 to be used.

Closes #1588

I thought I tested this, but obviously I did not.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, refactor:,
    docs:, chore:, test:, ci: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in example.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

#1577

@Gustl22 Gustl22 requested a review from spydon July 31, 2023 13:39
@Gustl22 Gustl22 changed the title fix(android): Restore support for AGP7 revert(android): Uupgrade androidx.core:core-ktx, restore support for AGP7 Aug 1, 2023
@Gustl22 Gustl22 changed the title revert(android): Uupgrade androidx.core:core-ktx, restore support for AGP7 revert(android): Upgrade androidx.core:core-ktx, restore support for AGP7 Aug 1, 2023
@Gustl22 Gustl22 merged commit f6bf126 into main Aug 1, 2023
@Gustl22 Gustl22 deleted the gustl22/1588-revert-android branch August 1, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hard to build an APK when using this package
2 participants