deps!: Update min Flutter to v3.13.0, compatibility with v3.16.8 #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spydon
approved these changes
Nov 29, 2023
|
This is a |
Thank you, wasn't aware of that tag. |
Gustl22
changed the title
spydon
approved these changes
Nov 30, 2023
2 tasks
|
The tests are still failing due to an not handled error from the native stream, which is caught, but still propagated to the framework. I currently try to determine the source. |
7 tasks
Gustl22
changed the title
7 tasks
|
Blocked by #1732 |
…on' into gustl22/upgrade-flutter
spydon
approved these changes
Jan 9, 2024
Gustl22
force-pushed
the
gustl22/upgrade-flutter
branch
2 times, most recently
from
ff2a2ba to
1a942d3
Compare
Gustl22
force-pushed
the
gustl22/upgrade-flutter
branch
from
1a942d3 to
62dd9f8
Compare
Gustl22
changed the title
This reverts commit 6387614.
Gustl22
force-pushed
the
gustl22/upgrade-flutter
branch
from
6d9b65f to
2016b44
Compare
Gustl22
force-pushed
the
gustl22/upgrade-flutter
branch
from
2016b44 to
c4c522c
Compare
This reverts commit c4c522c.
spydon
pushed a commit
that referenced
this pull request
Jan 19, 2024
# Description
Wait simultaneously for async calls (Futures and Streams) to ensure all
errors are propagated through one common future. Previously a stream
could throw an error before it was even listened to, as the process
still awaited an async call (here `setSource`).
## Checklist
<!-- Before you create this PR confirm that it meets all requirements
listed below by checking the
relevant checkboxes (`[x]`). This will ensure a smooth and quick review
process. -->
- [x] The title of my PR starts with a [Conventional Commit] prefix
(`fix:`, `feat:`, `refactor:`,
`docs:`, `chore:`, `test:`, `ci:` etc).
- [x] I have read the [Contributor Guide] and followed the process
outlined for submitting PRs.
- [x] I have updated/added tests for ALL new/updated/fixed
functionality.
- [x] I have updated/added relevant documentation and added dartdoc
comments with `///`, where necessary.
- [ ] I have updated/added relevant examples in [example].
The tests are adapted, but not explicitly written to avoid that error.
But the error would occur since Flutter 3.16.x, so they are tested
against in #1715 without further ado.
## Breaking Change
- [ ] Yes, this is a breaking change.
- [x] No, this is *not* a breaking change.
## Related Issues
#1715
<!-- Links -->
[issue database]: https://github.com/bluefireteam/audioplayers/issues
[Contributor Guide]:
https://github.com/bluefireteam/audioplayers/blob/main/contributing.md#feature-requests--prs
[Conventional Commit]: https://conventionalcommits.org
[example]:
https://github.com/bluefireteam/audioplayers/tree/main/packages/audioplayers/example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update minimum required Flutter version to 3.13.0 as Linux requires at least that version to work properly due to a bug.
Therefore we also only test against 3.13.0 and higher (here 3.16.1).
Also remove
dartdocdependency introduced in 7ca5058 as the package is integrated in dart SDK since v5.0.0.Fix pump Linux, introduced in flutter/flutter#135266 (flutter/flutter@5def6f2)
Checklist
fix:,feat:,refactor:,docs:,chore:,test:,ci:etc).///, where necessary.Breaking Change
Migration instructions
Related Issues